[Bug 878644] Review Request: openshift-origin-broker-util -Utility scripts for the OpenShift Origin broker

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878644

Michael Scherer <misc@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misc@xxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |misc@xxxxxxxx
              Flags|                            |fedora-review?

--- Comment #1 from Michael Scherer <misc@xxxxxxxx> ---
After reading the code, I have 3 remarks :
- /tmp usage is IMHO to be avoided (
https://github.com/openshift/origin-server/pull/507 )

- there is a few missing requires :
host and nsupdate would need bind-utils rpm ( used in oo-register-dns among
others )
curl need curl rpm ( used oo-accept-broker )
rngd is not pulled anywhere, but used in some script ( oo-setup-bind )
openssl is used to create certificate in oo-setup-broker , so should be
required

- requires is wrong :
Requires:       openshift-broker
in fedora, that's openshift-origin-broker

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]