Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876409 --- Comment #17 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- (In reply to comment #16) > "If it builds, ship it" is not a good policy. That's not what I said. Of course rpmlint doesn't find all problems, but this is no reason to omit it. Have a look at some of my reviews to see what I mean [1]. The rpmlint output and a complete checklist is always present, and if there are some other issues, I report them, as far as I've found them. By the way, I'm even not convinced about fedora-review. Well, it seems to make the reviewers' job easier, but it tempts to _not_ looking around the files and assume to that all is already done by this tool. That's why I don't use it. I've had such reviews for my own packages, with lots of impressive output and even a lot of useless stuff. But the actual problems haven't been found, so that I had to do more work after pushing it to testing. Just for clarifying that I don't prefer semi-automatic workflow. However, the package has been approved, the Git repo created, and it is on the way to the users. I know, most issues in packages come up after the review. But if we would consider this as a thing which happens anyway, we could stop reviewing packages in general. [1] https://bugzilla.redhat.com/buglist.cgi?resolution=CURRENTRELEASE&resolution=RAWHIDE&resolution=ERRATA&resolution=NEXTRELEASE&resolution=---&classification=Fedora&emailtype1=substring&query_format=advanced&emailassigned_to1=1&bug_status=ON_QA&bug_status=CLOSED&email1=mario.blaettermann%40gmail.com&component=Package%20Review&product=Fedora&list_id=853171 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review