Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=821285 Mo Morsi <mmorsi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #4 from Mo Morsi <mmorsi@xxxxxxxxxx> --- rpmlint produces a couple warnings, nothing serious but the macro-in-comment ones should be taken care of (just remove those comments) rubygem-bunny.src:73: W: macro-in-comment %{buildroot} rubygem-bunny.src:73: W: macro-in-comment %{gem_instdir} md5sums: $ md5sum bunny-0.8.0.gem.* 4fc1d4b2a448538ec88c1ad9ed2c5335 bunny-0.8.0.gem.srpm 4fc1d4b2a448538ec88c1ad9ed2c5335 bunny-0.8.0.gem.upstream Builds fine in Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4713563 Shame we can't run the tests, but looks like it for the same reason we aren't running them in the rubygem-pg rpm as a running server is required. Would be nice to look into a way to mock this stuff somehow at some point (perhaps we can build a component to take care of both cases if it doesn't exist), but obviously not a blocker for inclusion. Lastly I just want to ensure excluding the Gemfile from the package won't pose a problems. I did quickly try one of the examples from the rpm and it worked so I assume all is good. Everything else looks fine and is in accordance w/ the guidelines. ACK -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review