Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878612 Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review+ --- Comment #11 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> --- Good: * Former problems taken care of * Builds in koji * Permissions set properly * Package owns all files and directories that it creates and nothing more * All filenames valid utf-8 rpmlint * python3-pexpect.noarch: W: spelling-error %description -l en_US containts -> contains, con taints, con-taints Valid -- change to contains * python3-pexpect.noarch: W: spelling-error %description -l en_US passwd -> passed, password False positive. We're talking about /usr/bin/passwd here python3-pexpect.noarch: W: spelling-error %description -l en_US pty -> pry, pt, pity False positive. python3-pexpect.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/pexpect/FSM.py 0644L /usr/bin/env This one is a python module that happens to have a shebang line and some code that can be executed if the module were run like a script. However, that output is just an example of how to write code against the module's API -- it's not meant to actually be used on the system. So this can be ignored. * python-pexpect.noarch: E: zero-length /usr/lib/python2.7/site-packages/pexpect/tests/forwhich.sh python-pexpect.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/pexpect/tests/test_timeout_pattern.py 0644L /usr/bin/env [other non-executable scripts in the tests subdir] The tests aren't actually imported and used by the module. Makes sense to just remove these from the built rpm like this: %files [..] %exclude %{python_sitelib}/pexpect/tests/ %files -n python3-pexpect [..] %exclude %{python3_sitelib}/pexpect/tests/ 4 packages and 1 specfiles checked; 29 errors, 9 warnings. You can fix the one spelling error and add the %exclude's for the tests before you import this into git. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review