Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: zlib https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226671 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2007-02-16 16:16 EST ------- * the source is not one of those appearing on the home page. Moreover you could use the tar.bz2. * Is Prefix: %{_prefix} needed? * BuildRoot is not the preferred one * The comment in %build is misleading. It should better be something like # prepare Makefile for the static lib and in %install there could be a comment saying # the first make triggers compilation of the object files, linking of the # shared library and installs the library # The second make triggers the linking of the static library and # its installation * I think it would be better to have, in -devel http://www.zlib.net/manual.html and http://www.zlib.net/zlib_how.html * it seems to me that FAQ should be in %doc, and ChangeLog should be in the main package * -devel should Requires: zlib = %{version}-%{release} * It seems to me that there should be a make clean between the 2 make -f invocations, to trigger recompilation with the flags without -fPIC * I'll attach a patch to simplify the build and install, and use more macros. * zutil.h seems to be an internal header that should no be shipped * seems like that spec is not in utf8, certainly because of Glomsrød * remove the dots at the end of the Summaries Suggestion: Change %defattr(-,root,root) to %defattr(-,root,root,-) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review