[Bug 878430] Review Request: rubygem-apipie-rails - Rails REST API documentation tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878430

--- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
* Do not initiate the git repository
  - I guess that the "git init" could be avoided, if the Gemfile is removed
    for the test.

* Why are you dropping entire spec directory?
  - Since it is not required for runtime, we keep in in -doc subpackage
typically

* File permissions
  - You are fixing few file permissions in %install section. Since this is very
    likely an upstream error, have you reported it upstream (I see no relevant
    notice anywhere)?

* Missing runtime dependencies
  - Seems that you are entirely missing runtime dependencies.

    irb(main):001:0> require 'apipie-rails'
    NameError: uninitialized constant ActionDispatch

* License
  - jquery-1.7.2.js is dual licensed under the MIT or GPL Version 2 licenses.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]