Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871216 --- Comment #22 from Gustav Gonzalez <xtingray@xxxxxxxxx> --- (In reply to comment #20) > The build still isn't verbose enough. You should see the exact compiler > command executed. The configure script has an option "--with-debug" which prints the whole information about the compilation process. Should I add it in the configure line of the spec file? > The language handling isn't complete. While you're generating a list of > locale files in the install section, you're not actually using it in the > files section. Currently, the software use these files, which are installed by the "make install" command: ./share/tupi/data/translations/tupi_cs.qm ./share/tupi/data/translations/tupi_de.qm ./share/tupi/data/translations/tupi_da.qm ./share/tupi/data/translations/tupi_ru.qm ./share/tupi/data/translations/tupi_es.qm ./share/tupi/data/translations/tupi_gl.qm ./share/tupi/data/translations/tupi_pt.qm ./share/tupi/data/translations/tupi_ca.qm ./share/tupi/data/translations/tupi_it.qm >From the software I load the localization calling using these lines: QTranslator *translator = new QTranslator; translator->load(kAppProp->shareDir() + "data/translations/" + "tupi_" + locale + ".qm"); application.installTranslator(translator); I still don't get the relationship between this and the spec file. Should I change my code or what I have to do? > I'd personally remove the .bin extension from the executable and thus the > desktop file. There's a bash script called tupi, which defines the program variables first and then it calls the tupi.bin binary. How I should deal with this? > desktop-file-validate tupi.desktop > tupi.desktop: error: (will be fatal in the future): value "tupi.png" for key > "Icon" in group "Desktop Entry" is an icon name with an extension, but there > should be no extension as described in the Icon Theme Specification if the > value is not an absolute path > tupi.desktop: warning: value > "Application;Graphics;2DGraphics;RasterGraphics;" for key "Categories" in > group "Desktop Entry" contains a deprecated value "Application" This error is already fixed. > Please bump the release number of the spec file on changes and try to write > a meaningful changelog entry. This makes work easier for reviewers. It wont > be release 80. The number is only relevant for versions you publish. So > you'd be at 3 or 4 now. Ok. I will extend the changelog entry. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review