[Bug 876865] Review Request: Brewtarget - beer recipe tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=876865

--- Comment #10 from Pete Travis <me@xxxxxxxxxxxxxx> ---
<snip>
> 
> Issues: 
> 
> 1. Might ask upstream to include a copy of LGPL? (not a blocker)
> 
> 2. rpmlint says: 
> 
> brewtarget.i686: W: spurious-executable-perm
> /usr/share/man/man1/brewtarget.1.gz
> 3 packages and 0 specfiles checked; 0 errors, 1 warnings.
> 
> Might fix the perms on the man page when installing it. Should be 644. 
> 
> Thats a pretty minor issue, so if you could fix that before importing thats
> fine 
> with me and this package is APPROVED. 
> 
> I will go ahead and sponsor you, please let me know if you run into any
> questions... 
> 
> You can continue the process from: 
> https://fedoraproject.org/wiki/
> Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management
> _.28SCM.29_system_and_Set_Owner
> 
> Welcome to packaging fun! :)

I'll send a bug upstream on LGPL inclusion, and have corrected my install
evocation.

Kevin, thank you for your review, your sponsorship, and in general, the
incalculable value you add to the project.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]