Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871216 --- Comment #20 from Volker Fröhlich <volker27@xxxxxx> --- The build still isn't verbose enough. You should see the exact compiler command executed. The language handling isn't complete. While you're generating a list of locale files in the install section, you're not actually using it in the files section. I'd personally remove the .bin extension from the executable and thus the desktop file. desktop-file-validate tupi.desktop tupi.desktop: error: (will be fatal in the future): value "tupi.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path tupi.desktop: warning: value "Application;Graphics;2DGraphics;RasterGraphics;" for key "Categories" in group "Desktop Entry" contains a deprecated value "Application" Please bump the release number of the spec file on changes and try to write a meaningful changelog entry. This makes work easier for reviewers. It wont be release 80. The number is only relevant for versions you publish. So you'd be at 3 or 4 now. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review