Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | Flag| |fedora-review+ ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-02-16 08:45 EST ------- Okay. Two minor issues. * setup directory -------------------------------------------- %setup -q -n %{name}-%{version} -------------------------------------------- is okay with -------------------------------------------- %setup -q -------------------------------------------- because the default directory is %{name}-%{version} * For Requires/BuildRequires of perl modules: -------------------------------------------- BuildRequires: perl-XML-Parser -------------------------------------------- Well, for perl modules, the preferred style is -------------------------------------------- BuildRequires: perl(XML::Parser) -------------------------------------------- Anything else is okay. ----------------------------------------------- This package (ntfs-config) is APPROVED by me. ----------------------------------------------- Please fill up http://fedoraproject.org/wiki/Extras/CVSSyncNeeded and import this package after cvsadmin does some needed procedure. By the way, are you in need of sponsor? I see that you assigned some review requests to yourself, however as far as I know the person who can review the bug must be in fedorabugs group, and then must be in cvsadmin group... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review