https://bugzilla.redhat.com/show_bug.cgi?id=871191 --- Comment #3 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> --- So first a few quick things: 1. Your source0 url should be: https://github.com/kparal/%{name}/tarball/v%{version}#/%{name}-%{version}.tar.gz 2. Instead of: # installation removed the executable bit for some reason, but rpmlint then # complains (the file has a hashbang), so put the X bit back again chmod a+x %{buildroot}%{python_sitelib}/sendKindle.py do: sed -i '1d' sendKindle.py (in prep section) You are missing requires on python. Also as upstream you might want to considering supporting python 3. as for licensing, package is GPLv3+ and part 4 of the license states that "...;and give all recipients a copy of this License along with the Program.". You should therefore both as upstream and packager distribute text of the license together with the source code. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review