https://bugzilla.redhat.com/show_bug.cgi?id=875150 --- Comment #4 from Renich Bon Ciric <renich@xxxxxxxxxxxxxxxx> --- (In reply to comment #2) > Another set of issues: > > We usually don't want any *.a files in rpms, so the following should be > removed: > /usr/lib64/libmysqlclient.a > /usr/lib64/libmysqlclient_r.a > /usr/lib64/libmysqlservices.a ok, removed them using find > All config files should be marked as noreplace: > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#Configuration_files Done, I, also, moved the my.cnf to common and separated the client and server configs into their corresponding sub-packages > Unversioned libraries (*.so) should be in -devel subpackage: > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#Devel_Packages Ok, done. > You should run ldconfig: > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#Shared_Libraries Done. What should be the correct location of the post and postun in the kickstart? After %install? > If I see correctly, the packages rely on default datadir path, but we should > define one explicitelly, something like /var/lib/mariadb? Then the directory > should also be owned by -server subpackage: > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#The_directory_is_wholly_contained_in_your_package. > 2C_or_involves_core_functionality_of_your_package > > The rule above is valid also for log file. As up to now, these guys consider themselves a MySQL replacement. Most lib dirs and tools (/usr/bin) are named mysql*. The big issue with this is that the libclient files replace the mysql's client files. Also, libs is going to have issues with this. What I am saying is that it's either MySQL or MariaDB so far. The later works fine with the former's lib /var/lib dir. What to do? > I see /etc/my.cnf.d/client.cnf and /etc/my.cnf.d/mysql_clients.cnf are > packaged in -server subpackage, aren't they suppose to be included in > -client and -libs subpackage? Yeah, I put mysql_clients and client.cnf in the clients subpackage. Why do you mention libs? -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review