https://bugzilla.redhat.com/show_bug.cgi?id=875406 --- Comment #4 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> --- Good, thanks. Here are a couple more issues: Please increment the release value for each new version that you post to this bug. This will help to clarify to potential reviewers that you are changing the package. The Math::Combinatorics software is licensed under "the same terms as Perl itself", so the License field in the spec should be "GPL+ or Artistic". There are a couple older bits that you can remove if you will not be building for EPEL 5, and you'll only be building for EPEL 6. Can you clarify your intention? Lastly I see the software loads Data::Dumper, but the upstream author has commented out any code that uses Data::Dumper. This looks like a bug in the software that will lead to dependency bloat, so you should file a bug upstream and ask them to comment out the "use Data::Dumper" line. This will prevent RPM from automatically picking it up as a dependency for your package. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review