[Bug 871216] Review Request: Tupi Open 2D Magic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=871216

--- Comment #8 from Gustav Gonzalez <xtingray@xxxxxxxxx> ---
(In reply to comment #5)
> Make the build verbose!

I'm doing it now.

> As you are one of the developers, please try to remove the race conditions
> in the build system, so multiple workers can be used.

Done. Now it works!

> Use name and version macros in Source0.

Done.

> Every maintained release of Fedora has Qt > 4.7, therefore the version
> requirement should be removed.

Done.

> %{_datadir}/man/man1 must be %{_datadir}/man/man1/*.1* or the likes.
> Otherwise you're owning the directory.

Done.

> Change the permissions of source code files to 644; at least some have
> executable permissions. Same for COPYING and README.

Done.

> The postal address of the FSF is wrong in /usr/share/tupi/data/*/license.html

Fixed.

> Locales must be handled like this:
> http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files

I already read the link, but I would like to see the RPM source of a Qt
application (with .qm files) following this standard. 

I was looking for some of them to understand better what changes I have to do
in my source code, but my search was unsuccessful. 

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]