[Bug 875150] Review Request: MariaDB - An enhanced drop-in replacement for MySQL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=875150

--- Comment #2 from Honza Horak <hhorak@xxxxxxxxxx> ---
Another set of issues:

We usually don't want any *.a files in rpms, so the following should be
removed:
/usr/lib64/libmysqlclient.a
/usr/lib64/libmysqlclient_r.a
/usr/lib64/libmysqlservices.a

All config files should be marked as noreplace:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Configuration_files

Unversioned libraries (*.so) should be in -devel subpackage:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Devel_Packages

You should run ldconfig:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Shared_Libraries

If I see correctly, the packages rely on default datadir path, but we should
define one explicitelly, something like /var/lib/mariadb? Then the directory
should also be owned by -server subpackage:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#The_directory_is_wholly_contained_in_your_package.2C_or_involves_core_functionality_of_your_package

The rule above is valid also for log file.

I see /etc/my.cnf.d/client.cnf and /etc/my.cnf.d/mysql_clients.cnf are packaged
in -server subpackage, aren't they suppose to be included in -client and -libs
subpackage?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]