Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtkpod - Graphical song management program for Apple's iPod Alias: gtkpod-review https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228425 ------- Additional Comments From tmz@xxxxxxxxx 2007-02-15 23:53 EST ------- Hi Xavier, > * "cp %{SOURCE1} %{name}.desktop" from %prep section is useless. > you can directly use %{SOURCE1} in desktop-file-install entry. I realize that. It is more legible to me to have the cp in %prep as it is easier in the editor to see what file %{SOURCE1} is referencing. Also it puts it in the builddir so that if someone does a %prep and then checks out the builddir they will see the file there. > vendor id is not require anymore. > resume from guilines : > [ # The Vendor tag should not be used. It is set automatically by the build > system. ] That quote is from the section on spec file tags. It is for a Vendor: tag, not for the vendor option to desktop-file-install. See the section on .desktop files: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop > * You use an 48x48 icon, and i think it maybe souhld be install in > %{_datadir}/icons/ I thought that %{_datadir}/icons/ was for themeable icons and such. I know there are lots of packages from core and extras that install icons in %{_datadir}/pixmaps. I don't see anything in the guidelines about this. Do you know where I can find discussion or current best practices on this? > * You should add timestamp to make install: > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" I have never seen that required or recommended before. Could you tell me why you feel it is needed and where it is discussed or recommended? I use the install line straight from the specfile template in rpmdevtools. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review