[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=875506

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.blaettermann@xxxxxxxx
                   |                            |m

--- Comment #1 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
BuildRequires:  python-devel

You need either python2-devel or python3-devel. That's why it has to be
python2-devel in this case.


%description -n python3-fdb
Set of Firebird RDBMS bindings for Python. It works on Python 2.6+ and Python
3.

%description
Set of Firebird RDBMS bindings for Python. It works on Python 2.6+ and Python
3.

The last sentence doesn't make sense for the packages. Actually, due to that we
have separate packages for v2 or v3, such an info is useless.


Why does -doc require the python2 base package? It is actually not needed at
runtime. Vice versa, perhaps each of the base packages should require the -doc
package.


%description doc
Set of Firebird RDBMS bindings for Python. It works on Python 2.6+ and Python
3.

For the -doc package, the last sentence is OK, but please be more specific.
Suggestion:

%description doc
Documentation files for %{name}. It works on Python 2.6+ and Python 3.


rm -rf $RPM_BUILD_ROOT
is obsolete for ages. It is only needed if you want to provide your package for
EPEL 5.


The source tarball contains a bundled egg-info. Please remove it before
building your package (in the %prep section):

rm -rf %{upstream_name}.egg-info

See https://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs for more
information.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]