Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: coreutils https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225655 ------- Additional Comments From mastahnke@xxxxxxxxx 2007-02-15 22:22 EST ------- Sure, but again, I still don't have access to FedoraBugs group. Oh well. Everything looks good. Rpmlint does show some output, but it is understandable when profile* is in /etc. OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) OK - Package is code or permissible content. OK - Doc subpackage needed/used. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. XX - No rpmlint output. (Not a blocker IMO, I understand and agree with output) [builder@rawhide i386]$ rpmlint coreutils-6.7-5.i386.rpm E: coreutils setuid-binary /bin/su root 04755 E: coreutils non-standard-executable-perm /bin/su 04755 E: coreutils executable-marked-as-config-file /etc/profile.d/colorls.sh E: coreutils executable-sourced-script /etc/profile.d/colorls.sh 0755 E: coreutils executable-marked-as-config-file /etc/profile.d/colorls.csh E: coreutils executable-sourced-script /etc/profile.d/colorls.csh 0755 W: coreutils dangerous-command-in-%post mv SHOULD Items: OK - Should build in mock. OK- Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review