Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtkpod - Graphical song management program for Apple's iPod Alias: gtkpod-review https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228425 ------- Additional Comments From lxtnow@xxxxxxxxx 2007-02-15 20:35 EST ------- * "cp %{SOURCE1} %{name}.desktop" from %prep section is useless. you can directly use %{SOURCE1} in desktop-file-install entry. > Shouldn't it be fedora instead? The guidlines say "If upstream uses > <vendor_id>, leave it intact, otherwise use fedora as <vendor_id>." > I used fedora in the latest spec. vendor id is not require anymore. resume from guilines : [ # The Vendor tag should not be used. It is set automatically by the build system. ] * You use an 48x48 icon, and i think it maybe souhld be install in %{_datadir}/icons/ * Also add -p option to install (install -p -Dm 644 /.././) * You should add timestamp to make install: make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review