https://bugzilla.redhat.com/show_bug.cgi?id=840109 --- Comment #2 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- (In reply to comment #1) > Could you update to latest version 0.3.8 before I do a formal review ? Updated > Some notes > > - you don't have to compress the generated man page (will be done by > rpmbuild, and compression tool could change, one day) Removed. I did not know about this. Thanks! > - tests are currently installed in /usr/share/php, which is in the default > include_path. There is no Guidelines about this, but I think it's a bad > practice. > > Please consider moving to /usr/share/tests/php-lessphp > (you need to own /usr/share/tests or requires pear which own this dir) I have tried several ways to do this but I cannot come up with a "clean" solution (i.e. not hacking up the source and/or spec file). I will work with upstream to hopefully come up with a way to do this in a future release. > - sed (to add shebang) is a bit hard to read. > > Isn't simpler to use : > > sed -e '1i#!/bin/bash\n' -i %{libname}/tests/bootstrap.sh Fixed upstream via pull request :) Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-lessphp.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-lessphp-0.3.8-1.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review