https://bugzilla.redhat.com/show_bug.cgi?id=860542 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #4 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Thanks 1. SHOULD use %find_lang %{name} --with-kde which will pick up %{_kde4_docdir} stuff automatically, and you can remove it from %files 2. SHOULD fix %{_localstatedir}/opt/%{name} %{_localstatedir}/opt/%{name}/* which is redundant, just use %{_localstatedir}/opt/%{name}/ 3. SHOULD use %{_kde4_iconsdir}/hicolor/*/*/* instead of %{_kde4_iconsdir}/* 4. SHOULD use %{version} macro in Source url, which is currently, Source0: http://downloads.sourceforge.net/kchildlock/kchildlock/0.90.4.2/kchildlock-0.90.4.2.tar.gz as none of these are MUST blockers, APPROVED do please try to address them prior to issuing any official builds. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review