https://bugzilla.redhat.com/show_bug.cgi?id=873738 Ismael Olea <ismael@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ismael@xxxxxxxx) | --- Comment #4 from Ismael Olea <ismael@xxxxxxxx> --- (In reply to comment #2) > 1. Pre-release packages should have the .svnXXX suffix in Release field, not > in Version. They should be "Version: 1.0.2" and "Release: 0.1.svn20121003". > See: > http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages Fixed. I can't believe I did it so wrong. > 2. License tag is wrong. Should be "License: Sequence" > See: http://lists.fedoraproject.org/pipermail/legal/2012-November/002003.html Fixed. > 3. Javadoc package should not require the main package. Fixed. > 4. According this comment: > > # I really don't understand why _mavendepmapdir doesn't work as expected: > > #%{_mavendepmapdir} > It should be %{_mavendepmapfragdir} Seems I've been using outdated macros. Fixed. > 5. License file should be installed with javadoc package too. Fixed. > 6. %update_maven_depmap is unneeded. %post and %postun scriplets should be > removed (along with corresponding Requires). Fixed. > 7. Jar file should be installed unversioned, i.e. %{_javadir}/%{name}.jar. > Symlink should not be installed. > 8. Uhe URL tag is supposed to be used by users, so it should contain address > of a home website, not SVN repo. At the moment it's the more similar thing to a home website available. > 9. Packages should use upstream build method. Upstream uses gradle. Is there > any reason to use ant with custom build.xml instead? I understood gradle building does not fit with Fedora: https://lists.fedoraproject.org/pipermail/java-devel/2012-September/004540.html so I used the same approach here. > 10. There is "BuildRequires: jpackage-utils >= 0:1.6". Fedora ships version > 1.6 (or later) since 2004-12-01. IMO there is no reason for versioned > requires in this case. Fixed. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review