[Bug 865970] Review Request: dwlocstat - Tool for examining Dwarf location info coverage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=865970

--- Comment #2 from Petr Machata <pmachata@xxxxxxxxxx> ---
(In reply to comment #1)
> it seems there is code from elfutils bundled with it, and while I can see
> the reason, I think this should be agreed by the FPC, could you see with
> them ?

Thanks for review.  I went through the files, and the only actual copy from
elfutils is eu-config.h.  This was only used for likely() and unlikely()
predicates, and I can live without those, so I dropped eu-config.h.

known-dwarf.h is generated, I think I could hook it into a build process
eventually to mirror what's in system dwarf.h, but for now it is unused at all,
and I just dropped it.

The .cc and .hh files comprising dwlocstat itself (and dwarfstrings.c/.h as
well) grew up on elfutils "dwarf" branch.  But it's very unlikely that this
branch will get merged anytime soon (or ever), which is why I split this small
tool off to a separate project.  I don't think this counts as embedding a copy,
this code never was part of upstream elfutils tarball.

> ( and add the breakdown of the license ). 

I did that now.

The updated SRPM and SPEC are:
http://pmachata.fedorapeople.org/dwlocstat.spec
http://pmachata.fedorapeople.org/dwlocstat-0.1-0.2.20121105gitc55cb50.fc15.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]