[Bug 872966] Review Request: spacefm - SpaceFM file manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=872966

--- Comment #3 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> ---
You can also drop xz from the BuildRequires, it's already part of the minimal
build dependencies.

You could enable startup-notification support by adding
startup-notification-devel to the BuildRequires.

License is incorrect, there is no dual-licensing: spacefm source code is GPLv2+
but contains parts licensed under LGPLv2+. License tag should be:
# spacefm exo module is LGPLv2+
License: GPLv2+ and LGPLv2+

Take advantage of macros, especially in Source0, to make future updates of your
package easier:
http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.xz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]