https://bugzilla.redhat.com/show_bug.cgi?id=872783 --- Comment #7 from Jussi Lehtola <jussi.lehtola@xxxxxx> --- Your CXXFLAGS declaration is rather long, please split it on more lines. Note that you can replace cat Ray.1.man|sed 's/Erdős.*Rényi/Erdos-Renyi/g' | sed 's/é/e/g' | sed 's/É/E/g' | sed 's/ç/c/g' |sed 's/ő/o/g' > Ray.1 with the much more compact sed 's/Erdős.*Rényi/Erdos-Renyi/g;s/é/e/g;s/É/E/g;s/ç/c/g;s/ő/o/g' Ray.1.man > Ray.1 Still looking at just the specfile, the -extra package should own %{_datadir}/ray/ completely since none of the other packages place anything there. Otherwise %{_datadir}/ray/ %{_datadir}/ray/scripts/ will remain after the package has been uninstalled. ** In order for you to get sponsored you need to show your knowing of the Fedora guidelines, most importantly http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines In addition to the Packaging Guidelines, there are a bunch of language / application specific guidelines that are linked to in the Packaging Guidelines. Here are some tricks of the trade: http://fedoraproject.org/wiki/Packaging_tricks http://fedoraproject.org/wiki/Packaging/ScriptletSnippets http://fedoraproject.org/wiki/Common_Rpmlint_issues Please read these through. I will sponsor you if you do a couple of informal reviews from the review queue. Please review only packages *not* marked with FE-NEEDSPONSOR. I will have to do the full formal review after you to check that you have got everything correctly. Once I have sponsored you you will be able to do formal reviews of your own. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review