https://bugzilla.redhat.com/show_bug.cgi?id=872783 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@xxxxxx --- Comment #3 from Jussi Lehtola <jussi.lehtola@xxxxxx> --- A few notes: please put the declarations of the subpackages (%package followed by %description) directly after the main %description, before %setup. The %files sections belong to the end of the spec, before the %changelog. ** I'm a bit baffled by make HAVE_LIBZ=y HAVE_LIBBZ2=y module load mpi/openmpi-x86_64 Isn't this an MPI code, meaning that the MPI compiler should be already in use in the compilation stage? Please read through the MPI guidelines https://fedoraproject.org/wiki/Packaging:MPI#Packaging_of_MPI_software which your package should follow. Use the %{_openmpi_load} macro, which takes care of the correct architecture. ** The use of %{buildroot}/%{_bindir} is correct, but not very standard. %{buildroot}%{_bindir} does the same thing. ** Don't install the documentation by hand. # doc (ray-doc) mkdir -p %{buildroot}/%{_defaultdocdir}/ray/Documentation mkdir -p %{buildroot}/%{_defaultdocdir}/ray/RayPlatform/Documentation install -m 0644 Documentation/* %{buildroot}/%{_defaultdocdir}/ray/Documentation install -m 0644 RayPlatform/Documentation/* %{buildroot}/%{_defaultdocdir}/ray/RayPlatform/Documentation %files doc %{_defaultdocdir}/ray/Documentation/* %{_defaultdocdir}/ray/RayPlatform/Documentation/* This should be as simple as %files doc %doc Documentation/* %doc Rayplatform/Documentation/* Note that here the spurious Documentation directory is not included, as it is not really necessary (/usr/share/doc is already the place where documentation is placed). However, here all the files end up in the same place. If you want the Rayplatform stuff to be in a subdirectory, then you need to e.g. mkdir doc cp -ar RayPlatform/Documentation/ doc/Rayplatform %files doc %doc Documentation/* %doc doc/Rayplatform/ The trailing slash is not necessary, but it just makes explicit to the reader that it is a directory. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review