https://bugzilla.redhat.com/show_bug.cgi?id=821233 MartinKG <mgansser@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #22 from MartinKG <mgansser@xxxxxxxx> --- (In reply to comment #21) > Now that I already took a closer look, I'll do the review. > > > copied from buildlog: > cpio: vdr-plugin-live-0.2.0.99+cvs20121009/css/styles.cpp: Cannot stat: No > such file or directory > cpio: vdr-plugin-live-0.2.0.99+cvs20121009/javascript/treeview.cpp: Cannot > stat: No such file or directory > 2408 blocks > > shouldn't be a problem, right? agree > [!]: Package contains no bundled libraries. > > > Those #Fixme's in the spec are intentional, right? yes > I'd also appreciate it, if you could list BuildRequirements one per line. > I find it much more readable! done > javascript dir comes apparently from a different project, license is ASL 2.0 > vdr-live is licensed under GPLv2+, which is incompatible with ASL 2.0 > according to > https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses > > buildutils pot2i18n.pl is copied from somewhere else, Readme is referenced > but missing. > > live/js/mootools is copied from somewhere else, my educated guess, it comes > from http://mootools.net/ > License MIT (which is compatible with GPLv2+ > > > You should unbundle that stuff, at least that javascript piece. In this way, > IMHO, it can't be packaged in one package. hmm, why does zoneminder-1.25.0-9.fc18 comes with bundled mootools ? rpm -ql zoneminder |grep tools /usr/share/zoneminder/www/js/mootools.ext.js /usr/share/zoneminder/www/tools /usr/share/zoneminder/www/tools/mootools /usr/share/zoneminder/www/tools/mootools/mootools-core-1.3.2-nc.js /usr/share/zoneminder/www/tools/mootools/mootools-core-1.3.2-yc.js /usr/share/zoneminder/www/tools/mootools/mootools-core.js /usr/share/zoneminder/www/tools/mootools/mootools-more-1.3.2.1-nc.js /usr/share/zoneminder/www/tools/mootools/mootools-more-1.3.2.1-yc.js /usr/share/zoneminder/www/tools/mootools/mootools-more.js i need -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review