https://bugzilla.redhat.com/show_bug.cgi?id=821233 Matthias Runge <mrunge@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? --- Comment #21 from Matthias Runge <mrunge@xxxxxxxxxx> --- Now that I already took a closer look, I'll do the review. copied from buildlog: cpio: vdr-plugin-live-0.2.0.99+cvs20121009/css/styles.cpp: Cannot stat: No such file or directory cpio: vdr-plugin-live-0.2.0.99+cvs20121009/javascript/treeview.cpp: Cannot stat: No such file or directory 2408 blocks shouldn't be a problem, right? Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [!]: Package contains no bundled libraries. Those #Fixme's in the spec are intentional, right? I'd also appreciate it, if you could list BuildRequirements one per line. I find it much more readable! javascript dir comes apparently from a different project, license is ASL 2.0 vdr-live is licensed under GPLv2+, which is incompatible with ASL 2.0 according to https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses buildutils pot2i18n.pl is copied from somewhere else, Readme is referenced but missing. live/js/mootools is copied from somewhere else, my educated guess, it comes from http://mootools.net/ License MIT (which is compatible with GPLv2+ You should unbundle that stuff, at least that javascript piece. In this way, IMHO, it can't be packaged in one package. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review