https://bugzilla.redhat.com/show_bug.cgi?id=866901 --- Comment #15 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> --- Some comments too: 1) as I told you recently on IRC, sentences shouldn't be used in Summary; "Graphical user interface to programs that play the board game Go" may be enough. 2) On the contrary, use real sentences to describe the role of gogui in Description; by the way, here is an improved French description (for example, don't literally translate "Go Text", it's a standard: http://fr.wikipedia.org/wiki/Go_Text_Protocol): %description Gogui is a graphical interface to programs that play the game of Go and use the Go Text Protocol (GTP), such as GNU Go. GoGui has special features that are useful for Go program developers. %description -l fr_FR Gogui est une interface graphique pour les programmes de go implémentant le protocal Go Text Protocol (GTP), tels que GNU Go. Gogui présente des fonctionnalités utiles aux concepteurs de programmes Go. 3) You don't have to specify BuildRequires in sub-packages (see javadoc subpackage). BuildRequires must only be specified on the main package header section. 4) DON'T pipe sed through cat, it's useless, unreadable and considered bad practice. Simply use sed only instead: for FILE in bin/*; do if [ -f $FILE -a -x $FILE ]; then sed -e "s;^GOGUI_LIB=.*;GOGUI_LIB=\"%{_javadir}/%{name}\";" \ -e "s;^JAVA_DEFAULT=.*;JAVA_DEFAULT=\"$JAVA_DEFAULT\";" \ > $RPM_BUILD_ROOT%{_prefix}/$FILE chmod a+x $RPM_BUILD_ROOT%{_prefix}/$FILE fi done 5) You don't have to "manually" install documentation in %install target; use the %doc macro instead in files: - Remove this line: install -pm 644 doc/manual/html/*.html $RPM_BUILD_ROOT%{_defaultdocdir}/%{name} - Install HTML documentation in %files as below: %files ... %doc COPYING.html README.html doc/manual/html/*.html -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review