https://bugzilla.redhat.com/show_bug.cgi?id=868528 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-ZMQ-Constants.spec.old 2012-10-20 18:21:57.000000000 +0200 +++ perl-ZMQ-Constants.spec 2012-11-01 11:53:52.000000000 +0100 @@ -1,6 +1,6 @@ Name: perl-ZMQ-Constants Version: 1.01 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Constants for the libzmq library License: GPL+ or Artistic @@ -10,8 +10,11 @@ BuildArch: noarch +BuildRequires: perl(Cwd) BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(Test::More) +BuildRequires: perl(Carp) +BuildRequires: perl(Storable) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) @@ -28,10 +31,9 @@ make %{?_smp_mflags} %install -make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT +make pure_install DESTDIR=$RPM_BUILD_ROOT find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \; -find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; %{_fixperms} $RPM_BUILD_ROOT/* @@ -46,6 +48,9 @@ %changelog +* Thu Nov 1 2012 Jose Pedro Oliveira <jpo at di.uminho.pt> - 1.01-2 +- Handle comment #1 items of the review ticket #868528. + * Sat Oct 20 2012 Jose Pedro Oliveira <jpo at di.uminho.pt> - 1.01-1 - Update to 1.01. > TODO: Remove explicit deleting empty directories from %install section. This is not > needed anymore (perl-ZMQ-Constants.spec:34). -find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; Ok. > TODO: Replace PERL_INSTALL_ROOT with DESTDIR argument at make install. Modern > Makefile.PL recognizes DESTDIR (perl-ZMQ-Constants.spec:31). %install -make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT +make pure_install DESTDIR=$RPM_BUILD_ROOT Ok. > FIX: Remove bundled inc/* modules and build-require `perl(inc::Module::Install)' > instead of `perl(ExtUtils::MakeMaker)', or specify all dependencies needed for > bundled inc/* modules. +BuildRequires: perl(Cwd) Ok. > TODO: Build-require `perl(base)' for running tests (lib/ZMQ/Constants.pm:3). Not addressed. Ok. > TODO: Build-require `perl(Exporter)' for running tests (lib/ZMQ/Constants.pm:3). Not addressed. Ok. > FIX: Build-require `perl(Carp)' for running tests (lib/ZMQ/Constants.pm:4). +BuildRequires: perl(Cwd) Ok. > TODO: Build-require `perl(contstant)' for running tests (lib/ZMQ/Constants.pm:99). Not addressed. Ok. > TODO: Build-require `perl(Storable)' for running tests (lib/ZMQ/Constants/V3_1_2.pm:4). +BuildRequires: perl(Storable) Ok. $ rpmlint perl-ZMQ-Constants.spec ../SRPMS/perl-ZMQ-Constants-1.01-2.fc19.src.rpm ../RPMS/noarch/perl-ZMQ-Constants-1.01-2.fc19.noarch.rpm perl-ZMQ-Constants.src: W: spelling-error Summary(en_US) libzmq -> Librium perl-ZMQ-Constants.src: W: spelling-error %description -l en_US libzmq -> Librium perl-ZMQ-Constants.noarch: W: spelling-error Summary(en_US) libzmq -> Librium perl-ZMQ-Constants.noarch: W: spelling-error %description -l en_US libzmq -> Librium 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4646281). Ok. Please consider implementing the not-addressed `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review