https://bugzilla.redhat.com/show_bug.cgi?id=866901 --- Comment #13 from Florencia Fotorello <ffotorel@xxxxxxxxxx> --- Hello, Some informal comments: 1) You can use %{name}.desktop instead of gogui.desktop. 2) Regarding rpmlint output, just some comments, no action needed: -------------- gogui.noarch: I: enchant-dictionary-not-found fr_FR gogui.noarch: W: non-standard-group Unspecified -------------- Details: ===>>> gogui.noarch: I: enchant-dictionary-not-found fr_FR A dictionary for the Enchant spell checking library is not available for the language given in the info message. Spell checking will proceed with rpmlint's built-in implementation for localized tags in this language. ===>>> gogui.noarch: W: non-standard-group Unspecified All current versions of Fedora (and their respective RPM versions) treat the Group tag as optional. Packages may include a Group: field for compatibility with EPEL, but are not required to do so. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Group_tag 3) rpmlint output for .src.rpm is: ------------- gogui.src: I: enchant-dictionary-not-found fr_FR gogui.src: W: non-standard-group Unspecified gogui.src:115: E: files-attr-not-set gogui.src:116: E: files-attr-not-set gogui.src:117: E: files-attr-not-set gogui.src:118: E: files-attr-not-set gogui.src:119: E: files-attr-not-set gogui.src:120: E: files-attr-not-set gogui.src:121: E: files-attr-not-set gogui.src:122: E: files-attr-not-set gogui.src:123: E: files-attr-not-set gogui.src:124: E: files-attr-not-set gogui.src:125: E: files-attr-not-set gogui.src:128: E: files-attr-not-set gogui.src: W: no-cleaning-of-buildroot %install gogui.src: W: no-cleaning-of-buildroot %clean gogui.src: W: no-buildroot-tag gogui.src: W: no-%clean-section 1 packages and 0 specfiles checked; 12 errors, 5 warnings. ------------- Details: ===>>> gogui.src:115: E: files-attr-not-set This is now the default and no longer necessary to explicitly include. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_Permissions ===>>> gogui.src: W: no-cleaning-of-buildroot %install It’s only necessary for F-12 and below or EPEL 5. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25clean ===>>> gogui.src: W: no-buildroot-tag The BuildRoot tag isn't used in your spec. It must be used in order to allow building the package as non root on some systems. For some rpm versions (e.g. rpm.org >= 4.6) the BuildRoot tag is not necessary in specfiles and is ignored by rpmbuild; if your package is only going to be built with such rpm versions you can ignore this warning. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review