https://bugzilla.redhat.com/show_bug.cgi?id=868528 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- Source tar ball is original (SHA-256: cd6ac0155c013c530e6ab852b5fdcb540ea52806e95b175b7be0ad7373e34a97). Ok. Source and URL are usable. Ok. Summary verified from lib/ZMQ/Constants.pm. Ok. Description verified from lib/ZMQ/Constants.pm. Ok. License verified from lib/ZMQ/Constants.pm. Ok. Package does not contain any XS code, noarch BuilArch is Ok. TODO: Remove explicit deleting empty directories from %install section. This is not needed anymore (perl-ZMQ-Constants.spec:34). TODO: Replace PERL_INSTALL_ROOT with DESTDIR argument at make install. Modern Makefile.PL recognizes DESTDIR (perl-ZMQ-Constants.spec:31). FIX: Remove bundled inc/* modules and build-require `perl(inc::Module::Install)' instead of `perl(ExtUtils::MakeMaker)', or specify all dependencies needed for bundled inc/* modules. TODO: Build-require `perl(base)' for running tests (lib/ZMQ/Constants.pm:3). TODO: Build-require `perl(Exporter)' for running tests (lib/ZMQ/Constants.pm:3). FIX: Build-require `perl(Carp)' for running tests (lib/ZMQ/Constants.pm:4). TODO: Build-require `perl(contstant)' for running tests (lib/ZMQ/Constants.pm:99). TODO: Build-require `perl(Storable)' for running tests (lib/ZMQ/Constants/V3_1_2.pm:4). All tests pass. Ok. $ rpmlint perl-ZMQ-Constants.spec ../SRPMS/perl-ZMQ-Constants-1.01-1.fc19.src.rpm ../RPMS/noarch/perl-ZMQ-Constants-1.01-1.fc19.noarch.rpm perl-ZMQ-Constants.src: W: spelling-error Summary(en_US) libzmq -> Librium perl-ZMQ-Constants.src: W: spelling-error %description -l en_US libzmq -> Librium perl-ZMQ-Constants.noarch: W: spelling-error Summary(en_US) libzmq -> Librium perl-ZMQ-Constants.noarch: W: spelling-error %description -l en_US libzmq -> Librium 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-ZMQ-Constants-1.01-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Oct 30 10:50 /usr/share/doc/perl-ZMQ-Constants-1.01 -rw-r--r-- 1 root root 376 Oct 20 00:27 /usr/share/doc/perl-ZMQ-Constants-1.01/Changes -rw-r--r-- 1 root root 2958 Oct 30 10:50 /usr/share/man/man3/ZMQ::Constants.3pm.gz drwxr-xr-x 2 root root 0 Oct 30 10:50 /usr/share/perl5/vendor_perl/ZMQ drwxr-xr-x 2 root root 0 Oct 30 10:50 /usr/share/perl5/vendor_perl/ZMQ/Constants -rw-r--r-- 1 root root 10988 Oct 20 00:27 /usr/share/perl5/vendor_perl/ZMQ/Constants.pm -rw-r--r-- 1 root root 856 Jun 18 00:04 /usr/share/perl5/vendor_perl/ZMQ/Constants/V2_1_11.pm -rw-r--r-- 1 root root 689 Jun 18 00:04 /usr/share/perl5/vendor_perl/ZMQ/Constants/V3_1_1.pm -rw-r--r-- 1 root root 663 Jun 18 00:04 /usr/share/perl5/vendor_perl/ZMQ/Constants/V3_1_2.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-ZMQ-Constants-1.01-1.fc19.noarch.rpm |sort |uniq -c 1 perl(base) 1 perl(Carp) 1 perl(constant) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.16.1) 1 perl(Storable) 1 perl(strict) 1 perl(ZMQ::Constants) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-ZMQ-Constants-1.01-1.fc19.noarch.rpm |sort |uniq -c 1 perl(ZMQ::Constants) = 1.01 1 perl-ZMQ-Constants = 1.01-1.fc19 1 perl(ZMQ::Constants::V2_1_11) 1 perl(ZMQ::Constants::V3_1_1) 1 perl(ZMQ::Constants::V3_1_2) Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-ZMQ-Constants-1.01-1.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4638425). Ok. Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review