https://bugzilla.redhat.com/show_bug.cgi?id=870615 --- Comment #12 from Volker Fröhlich <volker27@xxxxxx> --- You uploaded the wrong file, that's not the SRPM. You're right about the binaries, I interpreted the rule wrong way. For the sake of consistency in your file, you could change mkdir -p %{buildroot}%{_unitdir} install -m 0644 -p %{SOURCE1} %{buildroot}%{_unitdir} to install -D -p -m 0644 -p %{SOURCE1} %{buildroot}%{_unitdir}/%{name}.service You can simplify the scriptlets like this: %preun %if 0%{?fedora} >= 15 || 0%{?rhel} >= 7 if [ $1 -eq 0 ] ; then # Package removal, not upgrade /bin/systemctl --no-reload disable %{name}.service > /dev/null 2>&1 || : /bin/systemctl stop %{name}.service > /dev/null 2>&1 || : fi %else #Umständlich angeschrieben, Stil angleichen if [ $1 = 0 ] ; then /sbin/service snmptt stop >/dev/null 2>&1 /sbin/chkconfig --del snmptt fi %endif --> %preun if [ $1 -eq 0 ] ; then %if 0%{?fedora} >= 15 || 0%{?rhel} >= 7 # Package removal, not upgrade /bin/systemctl --no-reload disable %{name}.service > /dev/null 2>&1 || : /bin/systemctl stop %{name}.service > /dev/null 2>&1 || : %else /sbin/service snmptt stop >/dev/null 2>&1 /sbin/chkconfig --del snmptt %endif fi If you don't want to simplify it, don't mix "-eq 0" and "= 0". Anyway, neither is a blocker and I can't find anything else to nag about. As soon as you upload the SRPM, I can start the formal review. Concerning the comment on top of the file: I think that's not related to packaging, but rather to the software itsself. If you're interested in that, please create a ticket upstream. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review