https://bugzilla.redhat.com/show_bug.cgi?id=869861 --- Comment #1 from Michael Scherer <misc@xxxxxxxx> --- Hi, sorry for being late, I was a little too sick for doing it right now. I have a few question : - some files are under a BSD license, shouldn't it be reflected somewhere ? - why pam-libra and pam-openshift provides/obsoletes ? ( I guess that's for internal reason of openshift, but once the transitition happened, this can be removed, I think ) - man page title is incorrect ( still use pam_libra ), I would suggest to regenerate it from the .xml, instead of using the copy shipped by upstream ( and ask to upstream to drop it, or at least, to place the needed code in the Makefile ) - I think there is some missing requires for shell scripts like attr and policycoreutils. They are likely installed by default, but as they are marked as optional, I would add them explicitly ( following the whole discussion on fedora minimal installation on -devel ) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review