https://bugzilla.redhat.com/show_bug.cgi?id=859795 --- Comment #8 from Guillermo Gómez <guillermo.gomez@xxxxxxxxx> --- I will only list pending issues (afaik): ===== MUST items ===== [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (2 clause)", "GPL (v2 or later)", "Unknown or generated". 3 files have unknown license. Detailed output of licensecheck in /home/gomix/Fedpkg/fedora-review/859795-sha/licensecheck.txt BSD (2 clause) -------------- /var/lib/mock/fedora-17-x86_64/root/builddir/build/BUILD/sha-1.0.4a/sha256.c GPL (v2 or later) ----------------- /var/lib/mock/fedora-17-x86_64/root/builddir/build/BUILD/sha-1.0.4a/ltmain.sh Unknown or generated -------------------- /var/lib/mock/fedora-17-x86_64/root/builddir/build/BUILD/sha-1.0.4a/version.h ===== SHOULD items ===== [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. All the above points regarding licencing should be addressed before approving. I think a separate LICENSE file is the best solution. Some files have their own headers which is perfectly ok, but some are not covered. Please review [1] for more details on howto proceed. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) The %clean section is not required for F-13 and above. Each package for F-12 and below (or EPEL 5) MUST have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). Include %clean section only if you plan to release a EPEL5 version (not a breaker). I dont see any more issues with this package to approve it :) Please try to address remaining issues, mainly licencing issues. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review