[Bug 870184] Review Request: drumkv1 - an old-school digital drumkit sampler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=870184

Volker Fröhlich <volker27@xxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volker27@xxxxxx

--- Comment #1 from Volker Fröhlich <volker27@xxxxxx> ---
desktop file validation belongs in the install section; no check section
required.

I suggest to include ChangeLog.

Please give a rationale for changing the compiler flags. Is it possibly
something upstream should incorporate?

Since Fedora has no older version of lv2 than 1.0.0, the version requirement is
not necessary.

It seems like the hidden .ui and .moc files are still present in the debuginfo
package.

You could use the version macro in Source0 one more time.

make %{?_smp_mflags} seems to work for me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]