https://bugzilla.redhat.com/show_bug.cgi?id=773485 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #14 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to comment #12) > (In reply to comment #11) > > - There is no desktop file for this package; should there be? > > Not sure if that makes much sense here, but I can add one if required. I'm just going off of the review guidelines for packages that contain a GUI. I'm not sure it makes much sense either, frankly, so don't worry about this unless somebody else yells. > > - See the last item (about perl) in the MUST section below. > > Is that really necessary? I can see it being for perl modules, but we're > just packaging some perl scripts here. Yes, you're right. We'll call this one a false alarm. > > - I see a few instances of the string "1.5.7" in the spec file. Should > > those be changed to %{version}? > > The only places that I see that is in %files - I think that adding macros > there > will save very little maintenance effort and just obfuscate the spec. No, I meant the two instances in %install: chmod -x %{buildroot}%{_libdir}/ibdm1.5.7/ibnl/* chrpath -d %{buildroot}%{_libdir}/*/libib{dm,is}.so.1.5.7 Fix those before import if you think they need to be fixed. Everything else looks good, so this package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review