https://bugzilla.redhat.com/show_bug.cgi?id=773485 --- Comment #11 from Jerry James <loganjerry@xxxxxxxxx> --- Executive summary: - The static library libibdmcom.a is in both -devel and -static - Add a comment to the spec file explaining the dual license - There is no desktop file for this package; should there be? - COPYING should be in -libs instead of the main package, since -libs can be installed without the main package - Is swig really needed at runtime? (It's a Requires). Just checking here; I don't know. - Is autoconf really a BR? It doesn't appear to be used. - See the last item (about perl) in the MUST section below. - fedora-review seems to be grumpy that you used Source: instead of Source0:; I don't care. - I see a few instances of the string "1.5.7" in the spec file. Should those be changed to %{version}? - The undefined weak symbols and unnecessary linkage noted in comment 6 are still there. You can get rid of the unnecessary linkage by doing this after %configure: # Workaround libtool reordering -Wl,--as-needed after all the libraries. sed -e 's|^LTCC="gcc"|LTCC="gcc -Wl,--as-needed"|' \ -e 's|^CC="g++"|CC="g++ -Wl,--as-needed"|' \ -i ibdm/libtool ibis/libtool ibmgtsim/libtool The undefined weak symbols can be eliminated by doing this before %configure: sed -i "s/^libibmscli_la_LIBADD =/& -lpthread/" ibmgtsim/src/Makefile.in Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= [!]: Static libraries in -static subpackage, if present. Note: ibutils-devel-1.5.7-5.fc19.i686.rpm : /usr/lib/libibdmcom.a See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries ===== MUST items ===== C/C++: [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. [!]: Static libraries in -static subpackage, if present. Note: ibutils-devel-1.5.7-5.fc19.i686.rpm : /usr/lib/libibdmcom.a Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [!]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Large documentation files are in a -doc subpackage, if required. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. [!]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [x]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Useful -debuginfo package or justification otherwise. Perl: [!]: Package contains the mandatory BuildRequires and Reguires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. [x]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. [!]: SourceX / PatchY prefixed with %{name}. Note: Source0 (ibutils-1.5.7.tar.gz) [x]: SourceX is a working URL. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ibutils-1.5.7-5.fc19.src.rpm ibutils-devel-1.5.7-5.fc19.i686.rpm ibutils-static-1.5.7-5.fc19.i686.rpm ibutils-1.5.7-5.fc19.i686.rpm ibutils-debuginfo-1.5.7-5.fc19.i686.rpm ibutils-libs-1.5.7-5.fc19.i686.rpm ibutils-devel.i686: W: no-documentation ibutils-static.i686: W: no-documentation ibutils.i686: W: no-manual-page-for-binary ibnlparse ibutils.i686: W: no-manual-page-for-binary dump2psl.pl ibutils.i686: W: no-manual-page-for-binary dump2slvl.pl ibutils-libs.i686: W: shared-lib-calls-exit /usr/lib/libibdm.so.1.1.1 exit@GLIBC_2.0 ibutils-libs.i686: W: shared-lib-calls-exit /usr/lib/libibdmcom.so.1.1.1 exit@GLIBC_2.0 ibutils-libs.i686: W: shared-lib-calls-exit /usr/lib/libibmscli.so.1.0.0 exit@GLIBC_2.0 ibutils-libs.i686: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 9 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint ibutils-libs ibutils ibutils-devel ibutils-static ibut ils-debuginfo ibutils-libs.i686: W: unused-direct-shlib-dependency /usr/lib/libibdm.so.1.1.1 /lib/libdl.so.2 ibutils-libs.i686: W: unused-direct-shlib-dependency /usr/lib/libibdm.so.1.1.1 /lib/libm.so.6 ibutils-libs.i686: W: shared-lib-calls-exit /usr/lib/libibdm.so.1.1.1 exit@GLIBC_2.0 ibutils-libs.i686: W: unused-direct-shlib-dependency /usr/lib/libibdmcom.so.1.1.1 /lib/libm.so.6 ibutils-libs.i686: W: shared-lib-calls-exit /usr/lib/libibdmcom.so.1.1.1 exit@GLIBC_2.0 ibutils-libs.i686: W: undefined-non-weak-symbol /usr/lib/libibmscli.so.1.0.0 pthread_cancel ibutils-libs.i686: W: undefined-non-weak-symbol /usr/lib/libibmscli.so.1.0.0 pthread_create ibutils-libs.i686: W: undefined-non-weak-symbol /usr/lib/libibmscli.so.1.0.0 pthread_cancel ibutils-libs.i686: W: undefined-non-weak-symbol /usr/lib/libibmscli.so.1.0.0 pthread_detach ibutils-libs.i686: W: unused-direct-shlib-dependency /usr/lib/libibmscli.so.1.0.0 /lib/libm.so.6 ibutils-libs.i686: W: shared-lib-calls-exit /usr/lib/libibmscli.so.1.0.0 exit@GLIBC_2.0 ibutils-libs.i686: W: unused-direct-shlib-dependency /usr/lib/libibsysapi.so.1.0.0 /lib/libm.so.6 ibutils-libs.i686: W: no-documentation ibutils.i686: W: no-manual-page-for-binary ibnlparse ibutils.i686: W: no-manual-page-for-binary dump2psl.pl ibutils.i686: W: no-manual-page-for-binary dump2slvl.pl ibutils-devel.i686: W: no-documentation ibutils-static.i686: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 18 warnings. # echo 'rpmlint-done:' Requires -------- ibutils-devel-1.5.7-5.fc19.i686.rpm (rpmlib, GLIBC filtered): ibutils-libs(x86-32) = 1.5.7-5.fc19 libibdm.so.1 libibdmcom.so.1 libibmscli.so.1 libibsysapi.so.1 ibutils-static-1.5.7-5.fc19.i686.rpm (rpmlib, GLIBC filtered): ibutils-devel(x86-32) = 1.5.7-5.fc19 ibutils-1.5.7-5.fc19.i686.rpm (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/perl graphviz-tcl ibutils-libs(x86-32) = 1.5.7-5.fc19 libc.so.6 libdl.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libibdmcom.so.1 libibumad.so.3 libm.so.6 libopensm.so.5 libopensm.so.5(OPENSM_1.5) libosmcomp.so.3 libosmcomp.so.3(OSMCOMP_2.3) libosmvendor.so.3 libosmvendor.so.3(OSMVENDOR_2.0) libpthread.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libtcl8.5.so rtld(GNU_HASH) swig tcl tk ibutils-debuginfo-1.5.7-5.fc19.i686.rpm (rpmlib, GLIBC filtered): ibutils-libs-1.5.7-5.fc19.i686.rpm (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6 libdl.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libibdmcom.so.1 libibumad.so.3 libm.so.6 libopensm.so.5 libopensm.so.5(OPENSM_1.5) libosmcomp.so.3 libosmcomp.so.3(OSMCOMP_2.3) libosmvendor.so.3 libosmvendor.so.3(OSMVENDOR_2.0) libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libtcl8.5.so rtld(GNU_HASH) Provides -------- ibutils-devel-1.5.7-5.fc19.i686.rpm: ibutils-devel = 1.5.7-5.fc19 ibutils-devel(x86-32) = 1.5.7-5.fc19 ibutils-static-1.5.7-5.fc19.i686.rpm: ibutils-static = 1.5.7-5.fc19 ibutils-static(x86-32) = 1.5.7-5.fc19 ibutils-1.5.7-5.fc19.i686.rpm: ibutils = 1.5.7-5.fc19 ibutils(x86-32) = 1.5.7-5.fc19 ibutils-debuginfo-1.5.7-5.fc19.i686.rpm: ibutils-debuginfo = 1.5.7-5.fc19 ibutils-debuginfo(x86-32) = 1.5.7-5.fc19 ibutils-libs-1.5.7-5.fc19.i686.rpm: ibutils-libs = 1.5.7-5.fc19 ibutils-libs(x86-32) = 1.5.7-5.fc19 libibdm.so.1 libibdmcom.so.1 libibis.so.1 libibmscli.so.1 libibsysapi.so.1 MD5-sum check ------------- http://www.openfabrics.org/downloads/ibutils/ibutils-1.5.7.tar.gz : CHECKSUM(SHA256) this package : 8db2fcb20102c37e7037826c58b899092df034aac870d3d50a13263746f17f18 CHECKSUM(SHA256) upstream package : 8db2fcb20102c37e7037826c58b899092df034aac870d3d50a13263746f17f18 Generated by fedora-review 0.3.0 (c78e275) last change: 2012-09-24 Buildroot used: fedora-rawhide-i386 Command line :/usr/bin/fedora-review -b 773485 -m fedora-rawhide-i386 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review