[Bug 866901] Review Request: gogui - GUI to play game of Go

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=866901

--- Comment #8 from Christophe Burgun <jouty@xxxxxxxxxxxxxxxxx> ---
Hi Florencia, Pierre-Yves

[!]: MUST Package contains a properly installed %{name}.desktop using desktop-
     file-install file if it is a GUI application.
=> The desktop file name follow now the guidelines %{name}.desktop

[!]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
     Note: Using both %{buildroot} and $RPM_BUILD_ROOT
=> I have solved this issue from the install desktop entry and change hard path
from the %post and %postun too.

[!]: MUST Rpmlint output is silent.
=> I have just the enchant-dictionary-not-found fr_FR which is normal

[!]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/Florencia/866901/gogui-1.4.6-src.tar.gz :
  MD5SUM this package     : a7cce6b4e314d0048f5e569e5fd43b73
  MD5SUM upstream package : 90da61b841b47a1c655c2a01205d2459
=> The Source0 url has been changed according sourceforge's url in the
guidelines 

==== Java ====
[!]: MUST Javadocs are placed in %{_javadocdir}/%{name} (no -%{version}
     symlink)
     Note: No /usr/share/javadoc/gogui found
=>[root@pollux gogui]# pwd
/var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILDROOT/gogui-1.4.6-2.fc19.x86_64/usr/share/javadoc/gogui
[root@pollux gogui]# ll
total 812
drwxr-xr-x. 4 builder mock   4096 23 oct.  16:55 .
drwxr-xr-x. 3 builder mock   4096 23 oct.  16:55 ..
-rw-r--r--. 1 builder mock  25487 23 oct.  16:55 allclasses-frame.html
-rw-r--r--. 1 builder mock  21667 23 oct.  16:55 allclasses-noframe.html
-rw-r--r--. 1 builder mock   8523 23 oct.  16:55 constant-values.html
-rw-r--r--. 1 builder mock   4235 23 oct.  16:55 deprecated-list.html
-rw-r--r--. 1 builder mock   8030 23 oct.  16:55 help-doc.html
-rw-r--r--. 1 builder mock 598749 23 oct.  16:55 index-all.html
-rw-r--r--. 1 builder mock   1497 23 oct.  16:55 index.html
drwxr-xr-x. 3 builder mock   4096 23 oct.  16:55 net
-rw-r--r--. 1 builder mock   2611 23 oct.  16:55 overview-frame.html
-rw-r--r--. 1 builder mock   7662 23 oct.  16:55 overview-summary.html
-rw-r--r--. 1 builder mock  45091 23 oct.  16:55 overview-tree.html
-rw-r--r--. 1 builder mock    403 23 oct.  16:55 package-list
drwxr-xr-x. 2 builder mock   4096 23 oct.  16:55 resources
-rw-r--r--. 1 builder mock  45659 23 oct.  16:55 serialized-form.html
-rw-r--r--. 1 builder mock  11139 23 oct.  16:55 stylesheet.css

The directory /usr/share/javadoc/gogui is here 

=> I have correct the directory ownership in %files section
and update %changelog section
=> I have change the patch name and comment it in spec file with upstream url

New link :

SPEC : http://jouty.fedorapeople.org/gogui.spec
SRPM : http://jouty.fedorapeople.org/gogui-1.4.6-2.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]