[Bug 868908] Review Request: rubygem-gem-nice-install - A RubyGems plugin that improves gem installation user experience

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=868908

--- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
* Source does not match upstream
  - According to review guidelines [1] "MUST: The sources used to build the
    package must match the upstream source, as provided in the spec URL."

    $ sha256sum gem-nice-install-0.1.0.gem*
      427f3eab95874a839c8514910d4a40a49e8b2102437621cfebbad03a9f43748a \
        gem-nice-install-0.1.0.gem
      1fa0d05cc62d42981be5bc3b183d68c2b4c82347b5f6341af6a31b117e043345 \
        gem-nice-install-0.1.0.gem.orig
    where the gem-nice-install-0.1.0.gem.orig is the gem I fetched from
upstream

* Remove the LANG=en_US.utf8
  - It is not needed according to my tests and the package builds just fine
    without it in Koji:

    http://koji.fedoraproject.org/koji/taskinfo?taskID=4620593

Otherwise the package looks good.

[1] http://fedoraproject.org/wiki/Packaging:ReviewGuidelines

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]