[Bug 868578] Review Request: re2 - C++ fast alternative to backtracking RE engines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=868578

Volker Fröhlich <volker27@xxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volker27@xxxxxx

--- Comment #1 from Volker Fröhlich <volker27@xxxxxx> ---
The build doesn't respect Fedora's compiler flags:
http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

Please remove the defattrs, as they are the default.

If you don't go for EPEL 5, remove the clean section, the rm in the install
section and the buildroot definition.

You don't need the LICENSE file in the devel package. Don't know whether the
README is useful there.

The description is very long and a bit like documentation in some sections.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]