[Bug 730764] Review Request: wxpdfdoc - A library for creating PDF documents in C++ with wxWidgets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=730764

--- Comment #10 from Domingo Becker <domingobecker@xxxxxxxxx> ---
(In reply to comment #8)
> 
> A lot of issues which needs some explanation.
> 
> The macro-in-comment-warnings can be avoided by escaping the macro with a
> second %.
> 

Fixed.

> Remove the executable bits from the source files before the package will be
> build.
> 

Fixed.

> Consider to use %global instead of %define:
> http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.
> 25define

Done.

Spec URL: http://beckerde.fedorapeople.org/wxpdfdoc/wxpdfdoc.spec

SRPM URL:
http://beckerde.fedorapeople.org/wxpdfdoc/wxpdfdoc-0.9.2.1-3.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]