https://bugzilla.redhat.com/show_bug.cgi?id=753577 --- Comment #17 from Andre Massing <andre.massing@xxxxxxxxx> --- (In reply to comment #12) Hi Alexey! I had a look at the newly added contrib section you posted in comment #12, here is a short summary of my "investigations": > I checked contrib/ for gmsh 2.6. In addition to modules described in > https://bugzilla.redhat.com/show_bug.cgi?id=753577#c3 there are few new ones > to review. We need to check (a) the license, (b) if we can/should replace > them with system copies of the libraries. > > 1. blossom/ As remarked in https://bugzilla.redhat.com/show_bug.cgi?id=753577#c13 this appears to be non-free. I could build the gmsh rpm with -DCMAKE_ENABLE_BLOSSOM:BOOL="OFF". > > 2. HighOrderMeshOptimizer/ > > Looks like it a separate module of gmsh itself. Need to double-check it. We should probably ask upstream :) > > 3. lbfgs/ > > Some sources from ALGLIB project - http://www.alglib.net/ License is GPLv2+ according to http://www.alglib.net/download.php > > 4. mmg3d/ > > MMG3D from http://www.math.u-bordeaux1.fr/~cdobrzyn/logiciels/mmg3d.php This is licensed under GPLv3 according to http://www.math.u-bordeaux1.fr/~cdobrzyn/logiciels/download/LICENCE.txt > > 5. rtree/ > > One header with C++ templated RTree implementation. > > 6. Salome/ > > Few source files extracted from Salome sources LGPLv2 according to http://www.salome-platform.org/downloads/license > > 7. voro++/ > > 3rd party library - http://math.lbl.gov/voro++/ http://math.lbl.gov/voro++/download/ Modified BSD (http://math.lbl.gov/voro++/download/). The license text is also part of the gmsh/contrib/voro++ source. The voro++ source in gmsh is pristine voro++ 0.4.4 plus one tiny bug fix according to a diff I did. Newest upstream of voro++ is 0.4.5 including this patch. So some possible actions - remove blossom - clarify HighOrderMeshOptimizer is part of gmsh - check whether lbfgs, Salome and mmg3d are modified and if not what to do about it (bundling vs. packaging) since the sources are not available as packages in fedora(AFAIK). What do you think? Are there any more actions need to be taken? I will write upstream and ask about these contrib sources in gmsh. Cheers, Andre -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review