https://bugzilla.redhat.com/show_bug.cgi?id=753577 --- Comment #15 from Andre Massing <andre.massing@xxxxxxxxx> --- (In reply to comment #11) Hi Alexey! > Hello Andre. > > I tried to build gmsh 2.6.1 recently. Summary: > - It mostly works > - Patches 1-3 should be updated to work with new sources. It is important > since these patches make gmsh to use systems copies of ANN and GMM. I already worked a little bit on your patches earlier this week and adapted them to gmsh 2.6.1, which required only a few modifications. If you want, you can download them from http://dl.dropbox.com/u/28662456/gmsh-cmake-soname.patch http://dl.dropbox.com/u/28662456/gmsh-api-demo-pathes.patch http://dl.dropbox.com/u/28662456/gmsh-use-system-ann.patch http://dl.dropbox.com/u/28662456/gmsh-use-system-gmm.patch But I only adapted them and did not recreate them so the time stamps and source paths in the patch header are still the old one. Not sure whether this is okay or whether some "patch policy" requires recreation against the new source directory? > > Plus additionally this one-liner is required to detemine libdir correctly: > > --- gmsh-2.5.0-source/CMakeLists.txt.old 2012-10-17 > 12:47:11.010138601 +0400 > +++ gmsh-2.5.0-source/CMakeLists.txt 2012-10-17 12:47:38.149134433 +0400 > @@ -976,7 +976,7 @@ > # mark targets as optional so we can install them separately if needed > # (e.g. "make lib" or "make shared" followed by "make install/fast") > install(TARGETS gmsh DESTINATION ${GMSH_BIN} OPTIONAL) > -install(TARGETS lib shared DESTINATION lib OPTIONAL) > +install(TARGETS lib shared DESTINATION ${LIB_INSTALL_DIR} OPTIONAL) > install(FILES ${GMSH_API} DESTINATION include/gmsh) > install(FILES ${WELCOME_FILE} DESTINATION ${GMSH_DOC} RENAME README.txt) > install(FILES ${LICENSE_FILE} DESTINATION ${GMSH_DOC}) Ah, great, I stumbled about the wrong LIB_INSTALL_DIR yesterday. > > I can update patches and spec in few days. I just need to test them > reasonably. > > If you can review the sources in contrib/* in details - it would be great. > My current understanding is that there is no option to use system copies of > libs. However, may be smth changed in gmsh 2.6 compared with 2.5. I havn't > looked into sources of 2.6 that detailed. I will have a look at it today. Best, Andre -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review