[Bug 858287] Review Request: gap-io - Unix I/O functionality for GAP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=858287

--- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> ---
(In reply to comment #3)
> The suggestion about correcting make install was to try to
> ensure the package is properly installed, in case it needs
> some special procedures during install, but besides broken
> install target, the package is simple enough to easily
> validated, and pass %check in spec as well as work in simple
> tests after install.

Yes, I'll try to figure out how to fix make install and pass the information
upstream, but it doesn't seem to be a trivial fix.

> Only issue, that you should correct when creating the
> git repository is to correct mixed $RPM_BUILD_ROOT and
> %{buildroot} usage.

Oops.  Good catch.  I'll fix that before importing the SRPM.  Thanks for the
review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]