https://bugzilla.redhat.com/show_bug.cgi?id=866982 --- Comment #5 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Update release number between release - You should bump the release number between each iteration of review. It helps to keep track of changes. You keep a record of changes in changelog as well. * Description wrapping - Isn't it strangely wrapped? Hint: single word on line. * Keep tests in -doc subpackage - We do not through out the test suite if it is part of the package. However, if there is -doc subpackage, the test suite should be moved there. See "MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity)." in [1]. * Keep the license in main package - See "MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc." in [1]. * Move rakefile.rb into -doc subpackage - Since this file is not required for runtime, I suggest to move it into -doc subpackage. [1] http://http://fedoraproject.org/wiki/Packaging:ReviewGuidelines -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review