[Bug 868038] Review Request: mate-system-monitor - Process and resource monitor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=868038

--- Comment #3 from leigh scott <leigh123linux@xxxxxxxxxxxxxx> ---
(In reply to comment #2)
> SHOULD:
> 
> Add quotes around "MATE" and "X-Mate" 
> 
> Add desktop-file-validate.
> 
> Please do this on initial import
> 
> Please also add Requires of "mate-desktop"
> 
> See below for examples for desktop-file-install:
> 
> http://vicodan.fedorapeople.org/matespec/mate-session-manager.spec
> 
> Installed/tested RPM. WORKS GOOD.
> 
> APPROVED.

No need to validate if you use desktop-file-install

desktop-file-install --delete-original             \
  --remove-category=MATE                           \
  --add-category=X-Mate                            \
  --dir $RPM_BUILD_ROOT%{_datadir}/applications    \
  $RPM_BUILD_ROOT%{_datadir}/applications/mate-system-monitor.desktop



Read the guideline, I've changed the desktop file so desktop-file-validate is
useless in this case.


https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files

desktop-file-install MUST be used if the package does not install the file or
there are changes desired to the .desktop file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]