https://bugzilla.redhat.com/show_bug.cgi?id=853124 --- Comment #4 from Matthias Runge <mrunge@xxxxxxxxxx> --- ok, before I'll do a full review: - BuildRoot not necessary anymore - clean section not required anymore - rm -rf %{buildroot] at beginning of install not required - drop defattr from files section - please be more specific in files section: %{_bindir}/%{name} %{_mandir}/man1/%{name}.1.* -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review