Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sonata - An elegant GTK+ client for the Music Player Daemon (MPD) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227181 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | Flag| |fedora-review+ ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-02-14 12:00 EST ------- Well, then I will do the formal review for sonata-1.0.1-1 * Python related Requies - Well, requirement related to python modules are not detected automatically by rpmbuild and this must be checked manually. So: --------------------------------------------------------- # LANG=C grep import `rpm -ql sonata` | grep -v Binary | sed -e 's|^.*:||' | sed -e 's|^[ \t][ \t]*||' | sort | uniq # import gnome, gnome.ui from SOAPpy import WSDL -> SOAPpy import ConfigParser import dbus -> dbus-python import dbus.glib -> dbus-python import dbus.service -> dbus-python import egg.trayicon -> gnome-python2-libegg import gc import getopt import gettext import gobject -> pygobject import gtk -> pygtk2 import locale import mmkeys import mpdclient3 import os import pango -> pygtk2 import shutil import socket import sonata import subprocess import sugar (not available) import sys import tagpy (not available) import threading import urllib, urllib2 ------------------------------------------------------------- So, please add "dbus-python gnome-python2-libegg" to Requires. Well, other things are okay. Please fix the issue above. ------------------------------------------------------ This package (sonata) is APPROVED by me. ------------------------------------------------------ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review