https://bugzilla.redhat.com/show_bug.cgi?id=866901 --- Comment #1 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> --- Some initial comments after having quickly looked at the spec file: - No %doc on the sources? - Some lines are really long... - Check if libfoo-devel requires libfoo, that would reduce the list of BuildRequires - Check the guidelines for install .desktop files - Check the guidelines regarding the icons (in %post and %postun) - There is no comment if the patch has been submitted upstream, has it? -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review